Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Panels: Remove beta label from Bar Chart, Candlestick, Histogram, State Timeline, & Status History Panels #58557

Merged
merged 2 commits into from Nov 29, 2022

Conversation

codeincarnate
Copy link
Collaborator

This PR removes the beta label from a number of panels that are now fairly stable and in common usage.

@codeincarnate codeincarnate requested review from a team, oscarkilhed and mdvictor and removed request for a team November 10, 2022 07:38
@codeincarnate codeincarnate added this to the 9.3.0 milestone Nov 10, 2022
@codeincarnate codeincarnate added the no-backport Skip backport of PR label Nov 10, 2022
@codeincarnate codeincarnate self-assigned this Nov 10, 2022
@codeincarnate codeincarnate changed the title Chore: Remove beta label from numerous panels Various Panels: Remove from Beta status Nov 10, 2022
@grafanabot
Copy link
Contributor

@nmarrs
Copy link
Contributor

nmarrs commented Nov 10, 2022

When updating panel status (alpha, beta, stable) the api_plugins_test.go backend test will fail. To update it we need to first set the updateSnapshotFlag to true in that file (see here for context) and then run make test-go locally to update the snapshot / fix the failing test. Then we can commit the updated snapshot to the PR to fix the build 👍

Writing this out as a future guide for myself, as in the past I've gotten blocked by this / assuming the flag was passed via CLI or something 😬

@nmarrs
Copy link
Contributor

nmarrs commented Nov 10, 2022

If we are adding this to the change log, maybe we should explicitly name which panels are no longer in beta in the PR title 🤔

@grafanabot
Copy link
Contributor

@leandro-deveikis leandro-deveikis modified the milestones: 9.3.0, 9.3.0-beta1 Nov 14, 2022
@grafanabot
Copy link
Contributor

This pull request was removed from the 9.3.0-beta1 milestone because 9.3.0-beta1 is currently being released.

@grafanabot grafanabot removed this from the 9.3.0-beta1 milestone Nov 15, 2022
@codeincarnate codeincarnate changed the title Various Panels: Remove from Beta status Bar Chart, Candlestick, Histogram, State Timeline, & Status History Panels: Remove Beta Label Nov 29, 2022
@codeincarnate codeincarnate changed the title Bar Chart, Candlestick, Histogram, State Timeline, & Status History Panels: Remove Beta Label Various Panels: Remove Beta Label from Bar Chart, Candlestick, Histogram, State Timeline, & Status History Panels Nov 29, 2022
@codeincarnate codeincarnate changed the title Various Panels: Remove Beta Label from Bar Chart, Candlestick, Histogram, State Timeline, & Status History Panels Various Panels: Remove beta label from Bar Chart, Candlestick, Histogram, State Timeline, & Status History Panels Nov 29, 2022
@codeincarnate codeincarnate added this to the 9.3.0 milestone Nov 29, 2022
@codeincarnate codeincarnate merged commit 839465a into main Nov 29, 2022
@codeincarnate codeincarnate deleted the codeincarnate/remove-beta-label branch November 29, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants