Loki: Make label browser accessible in query builder #58525
Conversation
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/41584 |
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/41761 |
grafanabot
added
enterprise-ok
enterprise-failed
and removed
enterprise-failed
enterprise-ok
labels
| it("doesn't render the label browser modal when closed", () => { | ||
| render(<LabelBrowserModal {...props} isOpen={false} />); | ||
| expect(screen.queryByRole('heading', { name: /label browser/i })).toBeNull(); | ||
| }); |
There was a problem hiding this comment.
Would also love to have a test case for onChange when we change the query. Feel free to drop it in another PR.
There was a problem hiding this comment.
This would be a good candidate for a follow-up task.
public/app/plugins/datasource/loki/querybuilder/components/LabelBrowserModal.tsx
Outdated
Show resolved
Hide resolved
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/42918 |
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/43029 |
public/app/plugins/datasource/loki/components/LokiLabelBrowser.tsx
Outdated
Show resolved
Hide resolved
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/43109 |
|
@ivanahuckova i like these suggestions! i'll make a pr for these changes.
#58525 (comment) - I wasn't sure how this will effect any of the other modals that already exist. my plan was to take a look to see if theres a way to increase the size for only a specific modal, in this case the label browser. if you think i would be better to just increase the size for all of them please let me know. |
What is this feature?
This PR makes the Label browser accessible from both the query builder and the code mode
Why do we need this feature?
During user interviews we learned that some users switch from the query builder to the code mode just to use label browser and then go back to builder mode, which is unnecessary
Who is this feature for?
...
Which issue(s) does this PR fix?:
Fixes #57744
Special notes for your reviewer:
...
Before:
After: