Oauth: Display friendly error message when role_attribute_strict=true and no valid role found #57818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalleep
requested review from
sakjur,
papagian and
zserge
and removed request for
a team
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/39717 |
Jguer
approved these changes
Oct 28, 2022
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/39739 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
For oauth integrations we are currently returning a generic error response with a 500 http status if role_attribute_strict is set to true and no valid role was provided for the user:
In this pr this behavior change to return a 401 http status code and a redirect to login page with a more descriptive message of why the login failed:
Which issue(s) does this PR fix?:
Fixes #49367
Fixes #36339