Alerting: Fix migration to create rules with group index 1 #56511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuri-tceretian
added
add to changelog
backport v9.1.x
yuri-tceretian
force-pushed
the
migration-bugs
branch
from
6480850
to
6ddf706
Compare
grafanabot
pushed a commit
that referenced
this pull request
Oct 7, 2022
(cherry picked from commit 3487e68)
grafanabot
pushed a commit
that referenced
this pull request
Oct 7, 2022
(cherry picked from commit 3487e68)
yuri-tceretian
added a commit
that referenced
this pull request
Oct 7, 2022
yuri-tceretian
added a commit
that referenced
this pull request
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, during migration Grafana creates new records in table
alert_rulewith value 0 in fieldrule_group_idx(default). Then during the next migration steps, Grafana reads the rules with the value 0 in that field and updates it to 1, and also creates a record in tablealert_rule_version.This can cause another problem: the migration can fail if there are too many records are inserted into the version table because they are inserted in bulk, and it causes (a bug?) error in XORM "Prepared statement contains too many placeholders".
This PR
alert_rule_versionto do this by a single row.