Azure Monitor: Fix empty Logs response for Alerting #56378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
requested review from
aangelisc and
yaelleC
and removed request for
a team
andresmgot
added
add to changelog
backport v9.1.x
andresmgot
changed the title
andresmgot
changed the title
|
Backend code coverage report for PR #56378
|
|
Frontend code coverage report for PR #56378 |
grafanabot
pushed a commit
that referenced
this pull request
Oct 5, 2022
(cherry picked from commit 8594e64)
grafanabot
pushed a commit
that referenced
this pull request
Oct 5, 2022
(cherry picked from commit 8594e64)
andresmgot
added a commit
that referenced
this pull request
Oct 5, 2022
andresmgot
added a commit
that referenced
this pull request
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Unified Alerting require empty frames to include no
datafield so I modified Azure Monitor Logs to check if there are rows in the response to return an empty frame.Which issue(s) this PR fixes:
Fixes #48072
Special notes for your reviewer:
ResponseTableToFrameis being used both in Azure Monitor Logs and Azure Resource Graph but the signature was dependendant of a Logs response so I refactored it a bit to be generic.