Azure Monitor: Fix subscription selector when changing data sources #56284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
added
add to changelog
backport v9.1.x
andresmgot
requested review from
asimpson and
aangelisc
and removed request for
a team
|
Backend code coverage report for PR #56284 |
|
Frontend code coverage report for PR #56284
|
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/36063 |
aangelisc
approved these changes
Oct 5, 2022
| }); | ||
| render(<ArgQueryEditor {...defaultProps} onChange={onChange} query={query} />); | ||
| expect(await screen.findByTestId('azure-monitor-arg-query-editor-with-experimental-ui')).toBeInTheDocument(); | ||
| expect(onChange).not.toHaveBeenCalledWith(expect.objectContaining({ subscriptions: ['foo'] })); |
There was a problem hiding this comment.
Nit: This assertion is unneeded as there's no reference to subscriptions: ['foo'] in this test.
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/36337 |
andresmgot
added a commit
that referenced
this pull request
Oct 6, 2022
papagian
pushed a commit
that referenced
this pull request
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When changing the data source, the list of subscriptions will change. This PR includes two fixes to adapt the Azure Resource Graph editor to that situation:
useRefdoes not change when using the editor in the template variable section (because the editor does not get re-mounted). I have changed that solution to useuseMemoinstead.Screencast.from.04-10-22.12.47.35.webm
Which issue(s) this PR fixes:
Fixes #55193
Special notes for your reviewer: