Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: RBAC handle error no resolver found #55676

Merged
merged 2 commits into from Sep 27, 2022

Conversation

gamab
Copy link
Contributor

@gamab gamab commented Sep 23, 2022

What this PR does / why we need it:

During the backport #54692, we forgot to catch the scope resolver error. This fixes the warning log problem some users have been facing.

Which issue(s) this PR fixes:

Fixes #55654

Special notes for your reviewer:

@gamab gamab force-pushed the gamab/fix/handle-err-no-resolver-found branch from 1f29635 to 2e9d759 Compare September 26, 2022 11:45
@grafana grafana deleted a comment from grafanabot Sep 26, 2022
@grafana grafana deleted a comment from grafanabot Sep 26, 2022
@grafana grafana deleted a comment from grafanabot Sep 26, 2022
@grafana grafana deleted a comment from grafanabot Sep 26, 2022
@grafanabot
Copy link
Contributor

@gamab gamab added this to the 9.1.7 milestone Sep 26, 2022
@gamab gamab marked this pull request as ready for review September 26, 2022 13:39
@gamab gamab requested a review from a team as a code owner September 26, 2022 13:39
@gamab gamab requested review from vtorosyan and removed request for a team September 26, 2022 13:39
@gamab gamab added add to changelog no-backport Skip backport of PR labels Sep 26, 2022
@vtorosyan
Copy link
Contributor

Do we need to backport already, since the 9.2 is branched off I believe?

@gamab
Copy link
Contributor Author

gamab commented Sep 27, 2022

This is going to 9.1.x, it fixes a backport we previously did. 9.2.x is already working correctly 👍

@gamab gamab merged commit f636564 into v9.1.x Sep 27, 2022
@gamab gamab deleted the gamab/fix/handle-err-no-resolver-found branch September 27, 2022 07:43
@iridos
Copy link

iridos commented Sep 29, 2022

We are getting a steady stream of about 400 messages per hour like [1] since upgrading to grafana 9.1.5 on 2022-09-14 - am I mistaken or will this fix our logspam?
Our messages differ from the one in #55654 by being errors, not warnings (and having a different msg part as well as a different logger etc)

[1] logger=context traceID=00000000000000000000000000000000 userId=0 orgId=1 uname= t=2022-09-29T11:31:43.653345729+02:00 level=error msg="Error from access control system" error="no resolver found"

@gamab
Copy link
Contributor Author

gamab commented Sep 29, 2022

@iridos yes, this should fix it. 🙂

@iridos
Copy link

iridos commented Sep 30, 2022

Great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants