Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live: Fix live streaming with live-service-web-worker feature flag enabled #55528

Merged
merged 1 commit into from Sep 21, 2022
Merged

Live: Fix live streaming with live-service-web-worker feature flag enabled #55528

merged 1 commit into from Sep 21, 2022

Conversation

ArturWierzbicki
Copy link
Contributor

fixes #55527

@ArturWierzbicki ArturWierzbicki added area/frontend no-changelog Skip including change in changelog/release notes backport v9.1.x Bot will automatically open backport PR labels Sep 20, 2022
@ArturWierzbicki ArturWierzbicki added this to the 9.1.7 milestone Sep 20, 2022
@ArturWierzbicki ArturWierzbicki requested a review from a team September 20, 2022 23:35
@grafanabot
Copy link
Contributor

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/34331

nmarrs
nmarrs approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@nmarrs nmarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes issue for me locally 🎉

@ryantxu
Copy link
Member

ryantxu commented Sep 21, 2022

I think anything worth backporting should be added to the changelog

otherwise looks great!

@ArturWierzbicki ArturWierzbicki added add to changelog and removed no-changelog Skip including change in changelog/release notes labels Sep 21, 2022
@ArturWierzbicki ArturWierzbicki merged commit 5a1f004 into main Sep 21, 2022
@ArturWierzbicki ArturWierzbicki deleted the #55527-fix-live-webworker branch September 21, 2022 11:09
@grafanabot grafanabot mentioned this pull request Sep 21, 2022
Merged
grafanabot pushed a commit that referenced this pull request Sep 21, 2022
@ArturWierzbicki @grafanabot
Live: Fix live streaming with live-service-web-worker feature flag …
0bada4d 
…enabled (#55528)

(cherry picked from commit 5a1f004)
ryantxu pushed a commit that referenced this pull request Sep 21, 2022
@grafanabot @ArturWierzbicki
Live: Fix live streaming with live-service-web-worker feature flag …
12e0b2e 
…enabled (#55528) (#55558)

(cherry picked from commit 5a1f004)

Co-authored-by: Artur Wierzbicki <wierzbicki.artur.94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmarrs nmarrs nmarrs approved these changes

Assignees

@ArturWierzbicki ArturWierzbicki

Labels
add to changelog area/frontend backport v9.1.x Bot will automatically open backport PR enterprise-failed
Projects
None yet
Milestone
9.1.7
Development

Successfully merging this pull request may close these issues.

Live: live-service-web-worker is broken
4 participants
@ArturWierzbicki @grafanabot @ryantxu @nmarrs