Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Add search index configuration options #55525

Merged
merged 8 commits into from Sep 20, 2022

Conversation

ArturWierzbicki
Copy link
Contributor

No description provided.

@ryantxu
Copy link
Member

ryantxu commented Sep 20, 2022

This makes me sad... but i think we need it. Lets put comments that this is temporary and may be removed in the future.

Ideally we can find a strategy that does not require any tuning -- but also need a way to unblock instances that may hit issues with page sizes etc

@ryantxu ryantxu changed the title Search: externalize search index config Search: Add search index configuration options Sep 20, 2022
@ArturWierzbicki ArturWierzbicki marked this pull request as ready for review September 20, 2022 22:25
@ArturWierzbicki ArturWierzbicki requested a review from a team September 20, 2022 22:25
@ArturWierzbicki ArturWierzbicki requested a review from a team as a code owner September 20, 2022 22:25
@grafanabot
Copy link
Contributor

@ArturWierzbicki ArturWierzbicki requested review from idafurjes, yangkb09 and ying-jeanne and removed request for a team September 20, 2022 22:25
@grafanabot
Copy link
Contributor

Copy link
Member

@ryantxu ryantxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! still nil value in test, but configs worked for me locally :)

@grafanabot
Copy link
Contributor

@ArturWierzbicki ArturWierzbicki enabled auto-merge (squash) September 20, 2022 23:00
@ArturWierzbicki ArturWierzbicki merged commit c3ca540 into main Sep 20, 2022
@ArturWierzbicki ArturWierzbicki deleted the externalize-search-settings branch September 20, 2022 23:09
@ArturWierzbicki ArturWierzbicki added backport v9.1.x Bot will automatically open backport PR and removed backport A backport PR labels Sep 20, 2022
@grafanabot
Copy link
Contributor

The backport to v9.1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-55525-to-v9.1.x origin/v9.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x c3ca5405cedf19e71ae644bbe62f7c1231eea3ec
# Push it to GitHub
git push --set-upstream origin backport-55525-to-v9.1.x
git switch main
# Remove the local backport branch
git branch -D backport-55525-to-v9.1.x

Then, create a pull request where the base branch is v9.1.x and the compare/head branch is backport-55525-to-v9.1.x.

ArturWierzbicki added a commit that referenced this pull request Sep 20, 2022
* Search: externalize config

* Search: update config descriptions

* Search: fix value

* Search: fix

* update

* Search: revert config values

* Search: rename copy/paste

* Search: fix tests

(cherry picked from commit c3ca540)
ryantxu pushed a commit that referenced this pull request Sep 21, 2022
* Search: externalize config

* Search: update config descriptions

* Search: fix value

* Search: fix

* update

* Search: revert config values

* Search: rename copy/paste

* Search: fix tests
ArturWierzbicki added a commit that referenced this pull request Sep 22, 2022
* Search: Add search index configuration options (#55525)

* Search: externalize config

* Search: update config descriptions

* Search: fix value

* Search: fix

* update

* Search: revert config values

* Search: rename copy/paste

* Search: fix tests

(cherry picked from commit c3ca540)

* fix merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants