New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting: Fix default query's data source when no default datasource specified #55435
Conversation
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/34093 |
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/34106 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-55435-to-v9.0.x origin/v9.0.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 20e6e0d59392e5a03b7ceb54bf7d16134a5f1484
# Push it to GitHub
git push --set-upstream origin backport-55435-to-v9.0.x
git switch main
# Remove the local backport branch
git branch -D backport-55435-to-v9.0.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-55435-to-v9.1.x origin/v9.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 20e6e0d59392e5a03b7ceb54bf7d16134a5f1484
# Push it to GitHub
git push --set-upstream origin backport-55435-to-v9.1.x
git switch main
# Remove the local backport branch
git branch -D backport-55435-to-v9.1.x Then, create a pull request where the |
What this PR does / why we need it:
This PR fixes the default query's data source when there is no data source marked as default