Logs: Add Download logs button to log-browser
#55163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/33388 |
matyax
approved these changes
Sep 14, 2022
| reportInteraction('grafana_logs_download_logs_clicked', { | ||
| app, | ||
| format: 'logs', | ||
| }); | ||
| const logsModel = dataFrameToLogsModel(data || [], undefined); |
svennergr
changed the title
Downloads button to log browserDownloads button to log browser
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/33427 |
svennergr
commented
Sep 16, 2022
| @@ -173,6 +173,7 @@ | |||
| "babel-loader": "8.2.5", | |||
| "babel-plugin-angularjs-annotate": "0.10.0", | |||
| "babel-plugin-macros": "3.1.0", | |||
| "blob-polyfill": "7.0.20220408", | |||
There was a problem hiding this comment.
I added that in order to add methods to the Blob object, which seem to be missing on JSDom.
Ref jsdom/jsdom#2555
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/33839 |
…nloads-button-more-prominent
svennergr
changed the title
Downloads button to log browserDownloads button to log browser
svennergr
changed the title
Downloads button to log browserDownload logs button to log log-browser
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/35521 |
joshhunt
reviewed
Sep 29, 2022
svennergr
deleted the
svennergr/50188-loki-datasource-make-the-downloads-button-more-prominent
branch
svennergr
changed the title
Download logs button to log log-browserDownload logs button to log-browser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP:
This is still work in progress as it
What this PR does / why we need it:
In #50188 we decided to add a new
Downloadsbutton to the logs browser. This browser supports only txt-format for now.Which issue(s) this PR fixes:
Fixes #50188
Preview of the feature:
Screen.Recording.2022-09-14.at.14.06.22.mov