Azure Monitor: Add support to customized routes #54829
Conversation
ms-hujia
requested review from
asimpson and
andresmgot
and removed request for
a team
|
|
grafanabot
added
area/backend
datasource/Azure
|
@ms-hujia thank you for your contribution 🎉 I've moved this to the Cloud Provider Plugins project for review/comments by the dev squad. |
There was a problem hiding this comment.
Hi @ms-hujia, sorry for the delayed response! I have some small suggestions / questions here.
|
It seems there are some weird errors in the CI, can you merge the latest status of Also, you have a pending review at grafana/grafana-azure-sdk-go#13 (review) we can continue with that PR before the merge this. |
andresmgot
changed the title
Sure, have rebased the branch and also fixed the comment in the PR of Azure SDK. |
There was a problem hiding this comment.
thanks @ms-hujia! we just need to upgrade the sdk here and we are ready to go
ms-hujia
requested review from
sakjur,
papagian and
zserge
and removed request for
a team
What this PR does / why we need it:
This PR aims to make it possible to use Grafana in specific non-public Azure cloud such as Azure Stack Hub. Unlike other pre-defined clouds, they have variable configurations for authentication and service endpoints for different instances. So, it's not possible to hardcode those configurations in code or generate by rules. After this PR, user can use Grafana Azure Monitor data-source to talk with Azure Monitor service endpoints in those specific Azure clouds not defined in the well-known list.
This PR mainly changes the backend of Azure Monitor data-source. The routes will be overridden by some extra configuration from data-source if the cloud is customized cloud. For now, the extra configuration is supposed to be configured by script automatically, while add corresponding UX is also possible.
Which issue(s) this PR fixes:
N/A.
Special notes for your reviewer:
For the cloud name indicating customization, it is hard coded as
AzureCustomizedCloudfor now and will be updated to a new entry inazsettingsif grafana/grafana-azure-sdk-go#13 is completed.