New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prometheus: Upgrades http client to 1.30 #53901
Conversation
Signed-off-by: bergquist <carl.bergquist@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR LGTM, but there were a lot of changes between 12.1 and 13.0 of the Prometheus client library so I recommend careful testing.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-53901-to-v9.1.x origin/v9.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x a74681036e1d455fee0543d1ae1481cee32f655d
# Push it to GitHub
git push --set-upstream origin backport-53901-to-v9.1.x
git switch main
# Remove the local backport branch
git branch -D backport-53901-to-v9.1.x Then, create a pull request where the |
Good point. lets run it internally for a while until we backport it to 9.1.x |
prometheus/client_golang#1117 is fixed now, so we should wait for v1.13.1 (or whatever's next) before backporting |
Signed-off-by: bergquist <carl.bergquist@gmail.com>
Creating a new PR was easier then resolving all merge conflicts in #47707
Contains the fix in prometheus/client_golang#1022
Signed-off-by: bergquist carl.bergquist@gmail.com