Grafana-ui: disables storybook controls that are irrelevant #35250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisobate
added
area/storybook
thisisobate
added this to In Review (max. internal 8, external 3)
in Frontend Platform Backlog
via automation
thisisobate
requested review from
dprokop and
jackw
and removed request for
mckn and
dprokop
24 tasks
|
Let's wait with this PR until 8.1. Due to a bug in storybook v6.2 the excluded controls are not passed as props on the first render to the stories, so we get lots of undefined props error storybookjs/storybook#14732. This should be fixed in Storybook v6.3. |
|
Alright 👍 |
Clarity-89
removed
the
old backport v8.0.x
thisisobate
moved this from In Review (max. internal 8, external 3)
to Bugs (max. 35)
in Frontend Platform Backlog
natellium
added this to In Review (max internal 8, max external 3)
in User essentials squad (deprecated)
via automation
thisisobate
force-pushed
the
controls-disabling-fix
branch
from
558d5d0
to
df639b4
Compare
User essentials squad (deprecated)
automation
moved this from In Review (max internal 8, max external 3)
to Done
Jul 5, 2021
bryanuribe
pushed a commit
to open-o11y/grafana
that referenced
this pull request
Aug 6, 2021
…35250) * Grafana-ui: disables storybook controls that are irrelevant * excluded unused control in Select story * made timeRange control visisble in GraphNG story
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR completely disables storybook controls that are irrelevant.
Which issue(s) this PR fixes:
Relates to #34417