Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Upgrade macaron #25869

Merged
merged 1 commit into from Jun 29, 2020
Merged

Chore: Upgrade macaron #25869

merged 1 commit into from Jun 29, 2020

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Jun 26, 2020

What this PR does / why we need it:
Upgrade to latest macaron version as versions below v1.3.7 are supposed to be affected by CVE-2020-12666, see #25856.

I've checked the differences between v1.3.4 and v1.3.9, don't see anything special.

Which issue(s) this PR fixes:

Fixes #25856.

@aknuds1 aknuds1 requested a review from a team as a code owner June 26, 2020 16:11
@aknuds1 aknuds1 requested review from papagian and marefr and removed request for a team June 26, 2020 16:11
@aknuds1 aknuds1 added this to the 7.1 milestone Jun 26, 2020
@aknuds1 aknuds1 requested a review from kylebrandt June 26, 2020 16:15
@aknuds1 aknuds1 added this to Under review in Backend Platform Squad Jun 26, 2020
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Copy link
Contributor

@jessabe jessabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aknuds1 aknuds1 requested a review from bergquist June 29, 2020 08:55
Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (looking at changes between version doesn't seem to introduce a breaking change for Grafana, but I may be wrong)

@aknuds1
Copy link
Contributor Author

aknuds1 commented Jun 29, 2020

@marefr The changes looked very minimal.

@aknuds1 aknuds1 merged commit dcd5752 into master Jun 29, 2020
Backend Platform Squad automation moved this from Under review to Done Jun 29, 2020
@aknuds1 aknuds1 deleted the chore/upgrade-macaron branch June 29, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Upgrade gopkg.in/macaron.v1 to v1.3.7 (or above)
4 participants