Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrumentation: Fix setting Jaeger tracing address through Grafana config #25768

Merged
merged 1 commit into from Jun 23, 2020
Merged

Instrumentation: Fix setting Jaeger tracing address through Grafana config #25768

merged 1 commit into from Jun 23, 2020

Conversation

marefr
Copy link
Member

@marefr marefr commented Jun 23, 2020

What this PR does / why we need it:
Upgrades jaeger-client-go to v2.24.0 to resolve problem with setting Jaeger tracing address through Grafana config.

Which issue(s) this PR fixes:
Fixes #25563

Special notes for your reviewer:

@marefr marefr requested a review from a team as a code owner June 23, 2020 13:51
@marefr marefr requested review from richardqlam, aknuds1 and papagian and removed request for a team and richardqlam June 23, 2020 13:51
@marefr marefr added this to the 7.1 milestone Jun 23, 2020
aknuds1
aknuds1 approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marefr marefr merged commit 5d1508e into master Jun 23, 2020
@marefr marefr deleted the 25563_fix branch June 23, 2020 17:23
aknuds1 pushed a commit that referenced this pull request Jun 30, 2020
@marefr @aknuds1
Instrumentation: Fix setting Jaeger tracing address through Grafana c…
e65f4c4 
…onfig (#25768)

Upgrades jaeger-client-go to v2.24.0 to resolve problem with setting Jaeger tracing 
address through Grafana config.

Fixes #25563
@mckn mckn mentioned this pull request Jul 1, 2020
Merged
@marefr marefr mentioned this pull request Apr 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknuds1 aknuds1 aknuds1 approved these changes

@papagian papagian Awaiting requested review from papagian

Assignees
No one assigned
Labels
add to changelog type/bug
Projects
None yet
Milestone
7.1-beta1
Development

Successfully merging this pull request may close these issues.

Not possible to set Jaeger tracing address through Grafana config
2 participants
@marefr @aknuds1