Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryEditor: Improve support for query editors when changing data source type #61280

Closed
mckn opened this issue Jan 11, 2023 · 2 comments
Closed

Comments

@mckn
Copy link
Contributor

mckn commented Jan 11, 2023

What happened:
During the work with #60218 I saw that we have duplicated logic for how to create and change queries. We have some logic used by alerting and some other logic being used by the dashboards/panel edit.

Currently, in alerting, we are not supporting changing data source properly. We keep some of the values in the query model even if you change to a data source of a completely different type. This can cause the query editor to break or behave unexpectedly.

What you expected to happen:
I think it would be a good idea to align the logic for creating and clearing queries when changing data sources or adding a new query. We should also apply the default values provided by the data source when clearing/adding queries.

References:

@soniaAguilarPeiron
Copy link
Member

should we close this one? I think this was fixed in this PR (see description)

@gillesdemey
Copy link
Member

Correct, closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

No branches or pull requests

3 participants