Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alerting: Use default queries when clearing/adding queries #63585

Open
soniaAguilarPeiron opened this issue Feb 22, 2023 · 1 comment · Fixed by #63092
Open

Alerting: Use default queries when clearing/adding queries #63585

soniaAguilarPeiron opened this issue Feb 22, 2023 · 1 comment · Fixed by #63092
Assignees
@soniaAguilarPeiron
Labels
area/alerting Grafana Alerting area/frontend internal for issues made by grafanistas type/bug

Comments

@soniaAguilarPeiron
Copy link
Member

soniaAguilarPeiron commented Feb 22, 2023 •
edited by timlevett

What happened:

We are not applying the default values provided by the data source when clearing/adding queries.

What you expected to happen:

Datasources may provide a default value for queries. We should use these default valuesin alerting when:

  • creating new alert (default values for form)
  • adding new query
  • changing the data source

This issue is related to this one: #61280

Grafana: 10.2.3
@soniaAguilarPeiron soniaAguilarPeiron self-assigned this Feb 22, 2023
@soniaAguilarPeiron soniaAguilarPeiron mentioned this issue Feb 22, 2023
Merged
@soniaAguilarPeiron
Copy link
Member Author

We reverted the changes in here , because the fix was causing several bugs.

@armandgrillet armandgrillet added the internal for issues made by grafanistas label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soniaAguilarPeiron soniaAguilarPeiron

Labels
area/alerting Grafana Alerting area/frontend internal for issues made by grafanistas type/bug
Projects
Alerting
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Alerting: Fix changing datasource and creating new query not using defaults. grafana/grafana
2 participants
@armandgrillet @soniaAguilarPeiron