Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Add default interval and interval_ms macros to sqlutil #982

Merged
merged 2 commits into from May 15, 2024
Merged

SQL: Add default interval and interval_ms macros to sqlutil #982

merged 2 commits into from May 15, 2024

Conversation

kevinwcyu
Copy link
Contributor

@kevinwcyu kevinwcyu commented May 9, 2024 •
edited

What this PR does / why we need it:

Adds default macros for $__interval and $__interval_ms so any sqlds-based data source can get it for free.

Which issue(s) this PR fixes:

Fixes grafana/grafana-aws-sdk#44

Special notes for your reviewer:
Will update sqlds after this is merged.

@kevinwcyu kevinwcyu requested a review from a team as a code owner May 9, 2024 19:52
@kevinwcyu kevinwcyu requested review from gabor, yesoreyeram and gwdawson and removed request for a team May 9, 2024 19:52
@CLAassistant
Copy link

CLAassistant commented May 9, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kevinwcyu kevinwcyu requested a review from iwysiu May 9, 2024 19:57
gabor
gabor approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@gabor gabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kevinwcyu kevinwcyu changed the title Add default interval and interval_ms macros to sqlutil SQL: Add default interval and interval_ms macros to sqlutil May 15, 2024
@kevinwcyu kevinwcyu merged commit 36b8fe3 into main May 15, 2024
3 checks passed
@kevinwcyu kevinwcyu deleted the kevinwcyu/add-default-interval-macros branch May 15, 2024 15:38
@kevinwcyu kevinwcyu mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabor gabor gabor approved these changes

@iwysiu iwysiu iwysiu approved these changes

@yesoreyeram yesoreyeram Awaiting requested review from yesoreyeram yesoreyeram is a code owner automatically assigned from grafana/oss-big-tent

@gwdawson gwdawson Awaiting requested review from gwdawson gwdawson is a code owner automatically assigned from grafana/oss-big-tent

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace $__interval and $__interval_ms
4 participants
@kevinwcyu @CLAassistant @gabor @iwysiu