backend/log: Add an "Off" log level and support dynamic log levels. #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds the ability to change the log level dynamically.
joeblubaugh
requested review from
wbrowne,
marefr and
xnyo
and removed request for
a team
|
Can you give an example where you would use this code, something you can link to? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds an "Off" log level, and adds the ability to dynamically change the level of an existing logger. The "Off" log level is useful for cleaning up test output when logging isn't needed, or as an emergency fix to stop logging sensitive data quickly. Dynamic log level support is also required for that capability.
Being able to dynamically change the logging level means that re-initialization of systems that share a logger isn't required when the logging level needs to change.