Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore mage_output_file.go in mage watch config #565

Merged
merged 1 commit into from Nov 18, 2022

Conversation

toddtreece
Copy link
Member

What this PR does / why we need it:

@yesoreyeram reported that the generation of mage_output_file.go was causing an infinite loop:

[Bra] 11-18 12:58:55 [DEBUG] Running: mage [-v reloadPlugin]
[Bra] 11-18 12:58:55 [ INFO] "$WORKDIR/mage_output_file.go": CREATE
[Bra] 11-18 12:58:55 [DEBUG] Running: mage [-v build:backend]

my best guess is that the plugin build is taking longer than build_delay for @yesoreyeram's plugin, and in my case it's completing and removing mage_output_file.go before the build_delay expires.

adding mage_output_file.go to the ignore_files list seems to fix this issue

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@toddtreece toddtreece requested a review from a team as a code owner November 18, 2022 13:51
@toddtreece toddtreece requested review from wbrowne and marefr and removed request for a team November 18, 2022 13:51
Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toddtreece toddtreece merged commit 701ffb5 into main Nov 18, 2022
@toddtreece toddtreece deleted the toddtreece/update-mage-watch-config branch November 18, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants