Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't use hardcoded cluster domain #962

Merged
merged 1 commit into from Mar 25, 2023
Merged

fix: don't use hardcoded cluster domain #962

merged 1 commit into from Mar 25, 2023

Conversation

weisdd
Copy link
Collaborator

@weisdd weisdd commented Mar 25, 2023

When calling grafana by service name, we don't have to rely on FQDN. The change reintroduces a fix similar to #791.

Fixes: #959

@weisdd weisdd self-assigned this Mar 25, 2023
@weisdd weisdd added the v5 A v5 specifc issue/feature label Mar 25, 2023
NissesSenap
NissesSenap approved these changes Mar 25, 2023
View reviewed changes
Copy link
Collaborator

@NissesSenap NissesSenap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NissesSenap NissesSenap merged commit df64e32 into master Mar 25, 2023
8 checks passed
@NissesSenap NissesSenap deleted the fix/hardcoded-cluster-domain branch March 25, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NissesSenap NissesSenap NissesSenap approved these changes

@HubertStefanski HubertStefanski Awaiting requested review from HubertStefanski HubertStefanski is a code owner

@pb82 pb82 Awaiting requested review from pb82 pb82 is a code owner

Assignees

@weisdd weisdd

Labels
v5 A v5 specifc issue/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot create dashboard on cluster with custom name
2 participants
@weisdd @NissesSenap