Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't use dashboard cache if url is different #841

Merged
merged 5 commits into from Nov 21, 2022

Commits on Oct 23, 2022

  1. fix: lift restriction on having both url and grafanacom specified in …

    …a dashboard spec
    
    There's a fallback logic in (r *DashboardPipelineImpl) obtainJson() that allows a user to have multiple sources for configuration with falling back to the next one in case of an error. For unknown reasons, having both url and grafanacom in spec was not allowed. This restriction should be lifted.
    weisdd committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    653ff1c View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. fix: don't use dashboard cache if URL is different, and other minor f…

    …ixes
    
    - for code simplification, moved from &metav1.Duration to metav1.Duration where the former was not really needed (GrafanaDashboardStatus, GrafanaSpec);
    - fix: for unknown reasons, NewDashboardPipeline would fallback to 24h instead of 0(=infinity) if dashboard.Spec.ContentCacheDuration is not defined. Removed that;
    - moved cache extraction from obtainJson() to loadDashboardFromURL(). - I think that location makes more sense;
    - fix: don’t use dashboard cache if url is different.
    weisdd committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    7caf96e View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Merge branch 'master' into fix/cache-url

    Edvin N committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    08275f9 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' into fix/cache-url

    Edvin N committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    a3c2cc1 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'master' into fix/cache-url

    Edvin N committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    611294b View commit details
    Browse the repository at this point in the history