Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIx GrafanaNotificationChannel cr not have UID will cause the program to crash #751

Merged
merged 2 commits into from May 13, 2022
Merged

FIx GrafanaNotificationChannel cr not have UID will cause the program to crash #751

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4c4d4a
Update grafananotificationchannel_controller.go
gxg001 May 9, 2022
c8bb425
Merge branch 'master' into patch-2
gxg001 May 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion controllers/grafananotificationchannel/grafananotificationchannel_controller.go
View file
Open in desktop
Expand Up @@ -276,7 +276,10 @@ func (r *GrafanaNotificationChannelReconciler) reconcileNotificationChannels(req
if err := json.Unmarshal(processed, &rawJson); err != nil {
return reconcile.Result{}, err
}

if rawJson.UID == nil {
r.Log.Info(fmt.Sprintf("cannot process notificationchannel %v/%v, UID is nil", notificationchannel.Namespace, notificationchannel.Name))
return reconcile.Result{}, nil
}
if _, err = client.GetNotificationChannel(*rawJson.UID); err != nil {
status, err = client.CreateNotificationChannel(processed)
} else {
Expand Down