fix(GrafanaDashboard): properly finish reconciliation in onDashboardDeleted when dashboard is missing #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weisdd
requested review from
NissesSenap,
ishanjainn,
theSuess,
HVBE and
pb82
as code owners
weisdd
changed the title
theSuess
approved these changes
May 6, 2024
theSuess
force-pushed
the
fix/ondashboardeleted
branch
from
0b9ade2
to
3e8783e
Compare
…eleted when dashboard is missing
theSuess
force-pushed
the
fix/ondashboardeleted
branch
from
3e8783e
to
3114854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1504, we introduced a minor regression:
If a dashboard is deleted outside of the operator (e.g. through Grafana UI), then the operator skips Plugin and Status reconciliations. This PR should fix that.
Manual test case:
GrafanaDashboardCR (e.g. fromexamples/basic);GrafanaCR should contain a reference to the dashboard instatus.dashboards;GrafanaCR should no longer contain a reference to the dashboard instatus.dashboards.