bugfix - datasource controller was dropping secureJsonData #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses a bug introduced in the changeover to using the openapi Grafana library where the secureJsonData field was being dropped. To address this it's necessary to use the `UpdateDataSourceCommand` struct to ensure we're also not dropping the version if it's present. This is a bit counter-intuitive to use the `Update` struct here and perhaps worth looking at another solution at some point. Thanks to matt-delaney-cruise for the initial PR around this.
NissesSenap
requested review from
weisdd,
ishanjainn,
theSuess,
HVBE and
pb82
as code owners
HVBE
approved these changes
Apr 19, 2024
|
Out of curiosity (and thus no means for pressure 😉), when can we expect a new release containing this fix? I can then determine to either wait or to rollback to a previous version. |
|
@dj-wasabi most likely, we'll cut a release tomorrow. |
|
I worked with the operator for the first time today and spent two hours desperately trying to add values. :) I'm already looking forward to the new release |
|
Happy i found this issue/pr pretty quick, first time using the operator and didn't get passwords to work for my datasources. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a bug introduced in the changeover to using the openapi Grafana library where the secureJsonData field was being dropped.
To address this it's necessary to use the
UpdateDataSourceCommandstruct to ensure we're also not dropping the version if it's present.This is a bit counter-intuitive to use the
Updatestruct here and perhaps worth looking at another solution at some point.Thanks to @mdelaney committed for the initial PR #1488