chore: create e2e test for secureJsonData. #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smuda
requested review from
NissesSenap,
weisdd,
ishanjainn,
theSuess,
HVBE and
pb82
as code owners
smuda
force-pushed
the
feature/add-test-for-secureJsonData
branch
from
b6cab5a
to
5fadf42
Compare
smuda
changed the title
NissesSenap
reviewed
Apr 16, 2024
smuda
force-pushed
the
feature/add-test-for-secureJsonData
branch
from
5fadf42
to
cf91207
Compare
NissesSenap
reviewed
Apr 16, 2024
There was a problem hiding this comment.
I think this looks great, as you say, let's wait for the other PR to get merged.
Thanks allot for your work around this @smuda
I wrote a minor NIT comment. Other than that, I'm happy to merge this after the other PR is merged.
| - name: step-03 | ||
| try: | ||
| - script: | ||
| content: 'kubectl logs -n ${namespace} -l app=thanos-querier | grep "^Authorization:" | head -n 1' |
There was a problem hiding this comment.
Is there some kind of timeout value that we can set per step or something like that?
Maybe set something like 60 seconds.
I saw that the old CI ran for 180s waiting for a timeout.
There was a problem hiding this comment.
The default timeout is set in ´.chainsaw.yaml´ at 2m0s but I've now set a much shorter timeout for the two log-tasks.
NissesSenap
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a E2E test for making sure the secureJsonData is transferred all the way to thanos.
This test is supposed to fail until #1488 is merged. I propose we'll not merge until then.