Adding tests for grafana version

[NissesSenap]

We need to handle deployment fields for version. We also need to handle what happens if we set both of the values at the same time? Or should we just block that all together?

[theSuess]

I'd ignore the spec.version field if the container image has ben overwritten. I've envisioned the version field as an easy-to-use alternative specifying a deployment override. If the user knows what they're doing, they can override the image with a custom one.

The status field should report the correct version in any case

[theSuess]

The tests here fail as the getGrafanaImage never takes the deployment override into account. The deployment override takes place last and is merged with the deployment built by the operator.

grafana-operator/controllers/reconcilers/grafana/deployment_reconciler.go

Line 56 in ba4734b

err := v1beta1.Merge(deployment, cr.Spec.Deployment)

We can also add tests for this, but those testcases would only show bugs in the upstream merge function.