Cannot create dashboard on cluster with custom name

[ciomaire]

Describe the bug

On a k8s cluster with a custom cluster-name, grafana-operator is attempting to reconcile a dashboard using an incorrect service fqdn which includes .svc.cluster.local

Looks like the issue that was originally reported in #592 and fixed in #791

Version
v5.0.0-rc0

Suspect component/Location where the bug might be occurring
'.cluster.local' is hardcoded in the service fqdn in https://github.com/grafana-operator/grafana-operator/blob/master/controllers/reconcilers/grafana/grafana_service_reconciler.go#L49-L53

Runtime (please complete the following information):

• Grafana Operator Version v5.0.0

[NissesSenap]

Hmm so there is nothing that you can't change when it comes to how the ingress and service should look like, but the status field will not adapt to this, and it will probably be rather painful to do...

As a workaround, I would set prefer ingress config to true so you can use the operator. And to be honest it's not impossible that's the solution we will recommend in the future.
To be honest, the number of users that sets custom cluster names should be extremely limited since it's an antipattern.
But at the same time we could probably remove the svc.cluster.local from the status since it should be enough with the namespace.

[pb82]

@NissesSenap Yes, the original fix did exactly that, remove .svc.cluster.local. If it works without that, we could do the same, would that work on a cluster with a custom domain?

[weisdd]

Yeah, I think we should reintroduce the change. Should work just fine.

[weisdd]

@ciomaire the fix will be included in the next RC version.