Lack of extended validation for resyncPeriod

[cnCloXie]

Describe the bug

The GrafanaDashboard get resynced every 5 mins even have provided a different value(like 30d) to resyncPeriod.

Version

v5.4.0

To Reproduce
Steps to reproduce the behavior:

1. Create resource

apiVersion: grafana.integreatly.org/v1beta1
kind: GrafanaDashboard
metadata:
  name: dashboard-a
  labels:
    app: grafana
    grafana: dashboards
spec:
  folder: "A"
  resyncPeriod: 30d
  instanceSelector:
    matchLabels:
      dashboards: "grafana"
  json: ""

2. Check the LAST RESYNC field with kubectl get grafanadashboard dashboard-a and you can see it still gets synced every 5 mins and all the temporary changes on it have been reverted...

Expected behavior

Resync every 30d.

Suspect component/Location where the bug might be occurring
Please provide this if you know where this bug might occur otherwise leave as unknown

Screenshots
If applicable, add screenshots to help explain your problem.

Runtime (please complete the following information):

• OS: Linux
• Grafana Operator Version [v5.4.0]
• Environment: Kubernetes
• Deployment type: [deployed]

Additional context
Add any other context about the problem here.

[pb82]

@cnCloXie the problem is that 30d is not a valid duration, see here. You could write it as hours: resyncPeriod: 720h

[NissesSenap]

So let's solve this by making use of CRD validation, we can see an example on how to make sure you can't use anything above h

grafana-operator/api/v1beta1/grafanacontactpoint_types.go

Line 30 in ba4734b

// +kubebuilder:validation:Type=string

[weisdd]

After internal discussion, we decided that we should add additional validation rules for resyncPeriod to our CRDs to make sure k8s API server accepts only those values that can be parsed by Go runtime.

[cnCloXie]

Thank you guys !
Ah yes adding validation in the CR, complaining to the operator's logs or translating d/m/y into hours, either way will work for me which could make me myself be aware of my input mistake explicitly. Thank U for reply and the operator !