Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memberlist corrupted packets #85

Merged
merged 3 commits into from Dec 1, 2021
Merged

Conversation

pracucci
Copy link
Contributor

@pracucci pracucci commented Dec 1, 2021

What this PR does:
In this PR I'm upgrading memberlist (from our fork) to include grafana/memberlist#1 which fixes corrupted compound messages when we send > 255 messages or messages > 64KB.

Which issue(s) this PR fixes:
N/A

Checklist

  • Tests updated
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci requested a review from stevesg December 1, 2021 08:42
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci requested a review from stevesg December 1, 2021 08:50
Copy link
Contributor

@stevesg stevesg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM - check is not needed with the updated memberlist branch.

@pracucci pracucci merged commit ecaee1a into main Dec 1, 2021
@pracucci pracucci deleted the fix-memberlist-corrupted-packets branch December 1, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants