-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix template variables multi-select #855
Conversation
Use the following command to run this PR with Docker at http://localhost:3000:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to work when I create constants without quotes, but I don't think we should be modifying template variable values in components. That should be done in applyTemplateVars function in datasource
Good callout @bossinc, I'll take a look at just implementing this in |
@aangelisc Do you have an update on this? |
Hi @javisst, not yet - I'm hoping to get to this next week. |
…ata-explorer-datasource into andreas/fix-multi-select
Allow multi-select of template variables in the builder editor.
The problem here was that we were quoting the template variable values. I've tested this with multiple filters/group bys and the quoting doesn't seem necessary so I've removed it.
Let me know if you find any cases where this may not be the case!
Updated the docs to reflect that these variables will now work in the builder.
Also, a minor change to ensure there is a
table
selected in the query editor before we display the error asserting that there is no table schema.Fixes #823