Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always display all found wrapper jars and their checksum #5

Merged
merged 5 commits into from
Jan 14, 2020

Conversation

eskatos
Copy link
Member

@eskatos eskatos commented Jan 11, 2020

See #2

Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Always display all known and unknown found wrapper jars
alongside their checksum.

The display string building was pushed down from the Github Action main
function, so it's easier to reuse and test it.

Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
@eskatos eskatos added the enhancement New feature or request label Jan 11, 2020
@eskatos eskatos self-assigned this Jan 11, 2020
Signed-off-by: Paul Merlin <paul@gradle.com>
Copy link
Contributor

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work!

@eskatos eskatos merged commit fbc9d54 into master Jan 14, 2020
@eskatos eskatos deleted the eskatos/output-enhancements branch January 14, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants