increase lowest tested version for cross version tests #29174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bot-gradle test this |
|
I've triggered the following builds for you. Click here to see all build failures. |
donat
approved these changes
May 16, 2024
| @@ -34,7 +34,7 @@ class ReleasedVersionsDetails(currentBaseVersion: GradleVersion, releasedVersion | |||
|
|
|||
| init { | |||
| val lowestInterestingVersion = GradleVersion.version("0.8") | |||
| val lowestTestedVersion = GradleVersion.version("1.0") | |||
There was a problem hiding this comment.
This is the lowest version for the target distribution, right?
There was a problem hiding this comment.
both to my understanding, with this we would still run TAPI clients that are lower than 7.0.
running gradle3.0CrossVersionTest means running everything where 3.0 is involved also the 3.0 clients if not restricted.
blindpirate
approved these changes
May 16, 2024
reinsch82
deleted the
reinhold/increase-lowest-tested-version-for-cross-version-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only guarantee compatibility with Daemon versions equal or higher than 3.0.
So there is no need to test anything less than that.
Reviewing cheatsheet
Before merging the PR, comments starting with