Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ValidatePlugins test performance #29157

Merged
merged 1 commit into from
May 16, 2024

Conversation

reinsch82
Copy link
Contributor

Attempt to make impact on runtime of ValidatePlugins*Test less.

the tests of AbstractPluginValidationIntegrationSpec have been executed 2 times with the same parameters.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@reinsch82 reinsch82 self-assigned this May 15, 2024
@reinsch82 reinsch82 force-pushed the reinhold/fix-validate-plugins-test-performance branch from 6cff34b to d99ff7f Compare May 15, 2024 14:30
@reinsch82
Copy link
Contributor Author

@bot-gradle test this

@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you. Click here to see all build failures.

@reinsch82 reinsch82 marked this pull request as ready for review May 15, 2024 17:32
@reinsch82 reinsch82 requested a review from a team as a code owner May 15, 2024 17:32
Copy link
Collaborator

@blindpirate blindpirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing it!

@reinsch82 reinsch82 added this pull request to the merge queue May 16, 2024
@bot-gradle bot-gradle added this to the 8.9 RC1 milestone May 16, 2024
Merged via the queue into master with commit 20059a1 May 16, 2024
57 checks passed
@reinsch82 reinsch82 deleted the reinhold/fix-validate-plugins-test-performance branch May 16, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants