Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify explict --java-version in MultiProjectJvmApplicationInitIntegrationTest #29152

Merged

Conversation

blindpirate
Copy link
Collaborator

The test cases in MultiProjectJvmApplicationInitIntegrationTest attempt to initialize a project using Java 21 as the default value. This leads to the integration tests provisioning a local JDK, which we typically avoid on CI due to it causing flakiness.

This PR explicitly specifies the --java-version to match the Java version of the test JVM, thereby preventing the download of additional JDKs.

…tegrationTest`

The test cases in `MultiProjectJvmApplicationInitIntegrationTest` attempt
to initialize a project using Java 21 as the default value.
This leads to the integration tests provisioning a local JDK,
which we typically avoid on CI due to it causing flakiness.

This PR explicitly specifies the `--java-version` to match the Java version of the test JVM,
thereby preventing the download of additional JDKs.
Copy link
Member

@cobexer cobexer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blindpirate blindpirate added this pull request to the merge queue May 15, 2024
@bot-gradle bot-gradle added this to the 8.9 RC1 milestone May 15, 2024
@bot-gradle
Copy link
Collaborator

The merge queue build has failed. Click here to see all failures.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2024
@blindpirate blindpirate force-pushed the bz/flaky/MultiProjectJvmApplicationInitIntegrationTest branch from 3ed98da to 8c56a7a Compare May 16, 2024 01:30
@blindpirate blindpirate added this pull request to the merge queue May 16, 2024
Merged via the queue into master with commit 800cc32 May 16, 2024
25 checks passed
@blindpirate blindpirate deleted the bz/flaky/MultiProjectJvmApplicationInitIntegrationTest branch May 16, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants