Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project health for enterprise platform #29139

Merged
merged 3 commits into from
May 15, 2024

Conversation

tresat
Copy link
Member

@tresat tresat commented May 14, 2024

Ignore the failing test here.

@tresat tresat added the re:platformization Tracks work related to the platformization effort label May 14, 2024
@tresat tresat self-assigned this May 14, 2024
@tresat tresat added this to the 8.9 RC1 milestone May 14, 2024
@tresat
Copy link
Member Author

tresat commented May 14, 2024

@bot-gradle test this

@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you. Click here to see all build failures.

@tresat tresat mentioned this pull request May 14, 2024
@tresat tresat changed the title Fix project health for enterprise subproject Fix project health for enterprise platform May 14, 2024
Copy link

gitstream-cm bot commented May 14, 2024

⚠️ This PR appears to be lacking tests. Consider adding tests to cover the new functionality.

Copy link

gitstream-cm bot commented May 14, 2024

📊 Changes by Platform: this PR is 63% new code

2 platforms were affected (:warning: if possible, only one platform should have significant changes in a PR)

See details
Platform Added Lines % of Total Line Changes Deleted Lines % of Total Line Changes Files Changed % of Total Files Changed
enterprise 39 56% 23 33% 3 50%
null 5 7% 3 4% 3 50%

@tresat tresat marked this pull request as ready for review May 14, 2024 13:34
@tresat tresat requested review from a team and ldaley as code owners May 14, 2024 13:34
@tresat
Copy link
Member Author

tresat commented May 15, 2024

@bot-gradle test and merge

@bot-gradle bot-gradle added this pull request to the merge queue May 15, 2024
@@ -8,12 +8,23 @@ description = """Performance tests for the build scan plugin
| """.trimMargin()

dependencies {
testFixturesApi(project(":internal-performance-testing"))
testFixturesApi(libs.commonsIo)
performanceTestImplementation(project(":base-services"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 There is a risk here that the performance tests break, since we don't have this in our pipeline, but in the DV pipeline. We can go ahead merging the PR and see if it breaks, or you can run (part of) the performance test and see if it still runs, though it isn't trivial.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like they passed!

@@ -11,31 +11,35 @@ errorprone {
}

dependencies {
api(project(":build-operations"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check the individual dependency changes, I suppose if it works all is good 👍 .

Merged via the queue into master with commit 9188f5e May 15, 2024
59 of 61 checks passed
@bot-gradle bot-gradle deleted the tt/89/project-health-for-enterprise branch May 15, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
re:platformization Tracks work related to the platformization effort
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants