-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix project health for enterprise platform #29139
Conversation
@bot-gradle test this |
I've triggered the following builds for you. Click here to see all build failures. |
|
📊 Changes by Platform: this PR is 63% new code See details
|
@bot-gradle test and merge |
@@ -8,12 +8,23 @@ description = """Performance tests for the build scan plugin | |||
| """.trimMargin() | |||
|
|||
dependencies { | |||
testFixturesApi(project(":internal-performance-testing")) | |||
testFixturesApi(libs.commonsIo) | |||
performanceTestImplementation(project(":base-services")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 There is a risk here that the performance tests break, since we don't have this in our pipeline, but in the DV pipeline. We can go ahead merging the PR and see if it breaks, or you can run (part of) the performance test and see if it still runs, though it isn't trivial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like they passed!
@@ -11,31 +11,35 @@ errorprone { | |||
} | |||
|
|||
dependencies { | |||
api(project(":build-operations")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't check the individual dependency changes, I suppose if it works all is good 👍 .
Ignore the failing test here.