Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LightTree source data improvements #29137

Merged
merged 2 commits into from
May 15, 2024
Merged

LightTree source data improvements #29137

merged 2 commits into from
May 15, 2024

Conversation

h0tk3y
Copy link
Member

@h0tk3y h0tk3y commented May 14, 2024

  • Track the length of the suffix added by wrapping the code
  • Support producing the "root source data" for the root block (required in the future)
  • Keep blank lines in the document code
  • Refactor the API and use sites of the LanguageTreeBuilder
  • Deduplicate some parsing test utils

@h0tk3y h0tk3y requested a review from a team as a code owner May 14, 2024 11:10
@h0tk3y h0tk3y requested a review from jbartok May 14, 2024 11:10
@h0tk3y h0tk3y self-assigned this May 14, 2024
@h0tk3y
LightTree source data improvements
d4dd17e 
* Track the length of the suffix added by wrapping the code
* Change the index range logic: the range is the real index range, not including an extra index in the end;
* Support producing the "root source data" for the root block
* Keep blank lines in the document code
* Refactor the API and use sites of the `LanguageTreeBuilder`
@h0tk3y
Deduplicate some test utils
cbf1e39
@h0tk3y h0tk3y force-pushed the sigushkin/declarative-dsl/source-data-improvements branch from 62f3308 to cbf1e39 Compare May 14, 2024 22:06
@h0tk3y
Copy link
Member Author

h0tk3y commented May 14, 2024

@bot-gradle test this

@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you. Click here to see all build failures.

@h0tk3y
Copy link
Member Author

h0tk3y commented May 15, 2024

@bot-gradle test this

@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you. Click here to see all build failures.

@h0tk3y h0tk3y added this pull request to the merge queue May 15, 2024
@bot-gradle bot-gradle added this to the 8.9 RC1 milestone May 15, 2024
@bot-gradle
Copy link
Collaborator

The merge queue build has failed. Click here to see all failures.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2024
@h0tk3y h0tk3y added this pull request to the merge queue May 15, 2024
Merged via the queue into master with commit 78c364e May 15, 2024
60 checks passed
@h0tk3y h0tk3y deleted the sigushkin/declarative-dsl/source-data-improvements branch May 15, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eskatos eskatos eskatos approved these changes

@jbartok jbartok jbartok approved these changes

Assignees

@h0tk3y h0tk3y

Labels
in:declarative-dsl
Projects
None yet
Milestone
8.9 RC1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@h0tk3y @bot-gradle @eskatos @jbartok