Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MINA SSHD version #29095

Merged
merged 3 commits into from
May 15, 2024
Merged

Update MINA SSHD version #29095

merged 3 commits into from
May 15, 2024

Conversation

aquinney0
Copy link
Contributor

@aquinney0 aquinney0 commented May 10, 2024

Move the MINA SSHD library dependency to 2.12.0 from 2.10.0.

The 8.7.0 update to JGit and the underlying SSH implementation is not compatible with 2.10.0 of MINA SSHD, causing all SSH Git dependencies to result in build failures.

Fixes #28823

#28823

Context

Some background is in the linked issue. Previous versions of Gradle did not work with modern SSH protocols, which made it unable to use services like github.com for source dependencies. These shortcomings were addressed with plugins designed to specifically address this issue, but the release of 8.7.0 broke the entire JGit SSH subsystem, once again making SSH source dependencies unusable.

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

Move the MINA SSHD library dependency to 2.12.0 from 2.10.0.

The 8.7.0 update to JGit and the underlying SSH implementation is not
compatible with 2.10.0 of MINA SSHD, causing all SSH Git dependencies
to result in build failures.

Fixes gradle#28823

Signed-off-by: Andrew Quinney <aquinney@zynga.com>
@aquinney0 aquinney0 requested review from a team as code owners May 10, 2024 13:51
@aquinney0 aquinney0 requested review from jvandort and ov7a and removed request for a team May 10, 2024 13:51
@bot-gradle bot-gradle added from:contributor PR by an external contributor to-triage labels May 10, 2024
Signed-off-by: Andrew Quinney <aquinney@zynga.com>
Copy link

gitstream-cm bot commented May 14, 2024

📊 Changes by Platform: this PR is 95% new code

2 platforms were affected

See details
Platform Added Lines % of Total Line Changes Deleted Lines % of Total Line Changes Files Changed % of Total Files Changed
null 1 5% 1 5% 1 50%
software 19 90% 0 0% 1 50%

Copy link
Member

@ljacomet ljacomet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

This PR is complete and simple enough, it will be merged immediately.

@ljacomet
Copy link
Member

@bot-gradle merge

@bot-gradle bot-gradle added this pull request to the merge queue May 15, 2024
@bot-gradle bot-gradle added this to the 8.9 RC1 milestone May 15, 2024
Merged via the queue into gradle:master with commit bc39c72 May 15, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:contributor PR by an external contributor in:source-dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoSuchMethodError On any SSH Source Dependency
4 participants