Daemon toolchain auto-provisioning updateDaemonJvm generates download URLs #29022
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The
Daemon toolchain auto-provisioning mechanism
is part ofPhase 2
oftoolchain support for Gradle Daemon
, where the motivation behind it and other technical details can be found on the public spec document. ThisPR allows the
updateDaemonJvm
to populates thegradle-daemon-jvm.properties
with the download info by getting this info from JavaToolchainResolverRegistry (that was moved fromtoolchain-jvm
totoolchain-jvm-shared
together with minimum required dependencies, so it can be reused from the Launcher) following the format toolchainUrl . TheToolchainRepositoriesResolver.java
class created onbuild-configuration
is responsible to resolve the download URL for each platform and in case there are multiple applied JavaToolchainRepository just the first valid URL is taken into consideration similar to the already existing implementation.NOTE: This change was built on top of #28931 to avoid merge conflicts.
Testing
Unit tests:
UpdateDaemonJvmModifierTest.groovy
ToolchainRepositoriesResolverTest.groovy
Integration tests:
UpdateDaemonJvmIntegrationTest.groovy
Demo
Simple demo exposing how
updateDaemonJvm
task populates thegradle/gradle-daemon-jvm.properties
with the download toolchain url based on the appliedfoojay
resolve plugin.UpdateDaemonJvm.generates.download.URLs.mov
Contributor Checklist
<subproject>/src/integTest
) to verify changes from a user perspective<subproject>/src/test
) to verify logic./gradlew sanityCheck
./gradlew <changed-subproject>:quickTest