Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more content to architecture documentation #29017

Merged
merged 3 commits into from May 3, 2024
Merged

Conversation

adammurdoch
Copy link
Member

@adammurdoch adammurdoch commented May 2, 2024

Context

This PR fleshes out the "entry point" for the Gradle architecture to discuss a few important concepts in the Gradle internals.

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

Copy link
Member

@eskatos eskatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adammurdoch adammurdoch enabled auto-merge May 3, 2024 06:08
@adammurdoch adammurdoch added this pull request to the merge queue May 3, 2024
@bot-gradle bot-gradle added this to the 8.9 RC1 milestone May 3, 2024
Merged via the queue into master with commit 49c70c9 May 3, 2024
26 of 27 checks passed
@adammurdoch adammurdoch deleted the am/arch-docs branch May 3, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants