Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract PluginAuthorServices from plugins project #29010

Merged
merged 5 commits into from May 6, 2024

Conversation

tresat
Copy link
Member

@tresat tresat commented May 1, 2024

Removes the PluginAuthorServices class from the plugins project and distribute its components to more appropriate JVM platform projects.

This allows for removing further dependencies from plugins and should make these services easier to locate.

@tresat tresat self-assigned this May 1, 2024
tresat added 2 commits May 1, 2024 17:01
- Fix projectHealth check to remove removed deps from plugins project.
- Update nullability exceptions.
Copy link

gitstream-cm bot commented May 1, 2024

⚠️ This PR appears to be lacking tests. Consider adding tests to cover the new functionality.

Copy link

gitstream-cm bot commented May 1, 2024

📊 Changes by Platform: this PR is 93% new code

3 platforms were affected (:warning: if possible, only one platform should have significant changes in a PR)

See details
Platform Added Lines % of Total Line Changes Deleted Lines % of Total Line Changes Files Changed % of Total Files Changed
null 4 6% 5 7% 2 33%
software 15 22% 0 0% 1 17%
jvm 45 65% 0 0% 3 50%

@tresat tresat changed the title Remove PluginAuthorServices to see where it is used Extract PluginAuthorServices from plugins project May 6, 2024
@tresat tresat marked this pull request as ready for review May 6, 2024 12:09
@tresat tresat requested review from a team as code owners May 6, 2024 12:09
@tresat tresat requested a review from octylFractal May 6, 2024 12:09
@gradle gradle deleted a comment from tresat May 6, 2024
@tresat tresat added this to the 8.9 RC1 milestone May 6, 2024
Copy link

gitstream-cm bot commented May 6, 2024

📊 Changes by Platform: this PR is 93% new code

3 platforms were affected (:warning: if possible, only one platform should have significant changes in a PR)

See details
Platform Added Lines % of Total Line Changes Deleted Lines % of Total Line Changes Files Changed % of Total Files Changed
null 4 6% 5 7% 2 33%
software 15 21% 0 0% 1 17%
jvm 48 67% 0 0% 3 50%

@tresat
Copy link
Member Author

tresat commented May 6, 2024

@bot-gradle test this

@gradle gradle deleted a comment from tresat May 6, 2024
@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you. Click here to see all build failures.

@tresat tresat added the re:platformization Tracks work related to the platformization effort label May 6, 2024
@tresat
Copy link
Member Author

tresat commented May 6, 2024

@bot-gradle test and merge

@gradle gradle deleted a comment from tresat May 6, 2024
@bot-gradle bot-gradle added this pull request to the merge queue May 6, 2024
Merged via the queue into master with commit 92cff97 May 6, 2024
57 of 59 checks passed
@bot-gradle bot-gradle deleted the tt/experiments/delete-plugin-author-services branch May 6, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants