Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If a variant cannot be selected because there are no variants, mentio… #28971

Merged
merged 6 commits into from
May 10, 2024
Merged

If a variant cannot be selected because there are no variants, mentio… #28971

merged 6 commits into from
May 10, 2024

Commits on Apr 25, 2024

  1. If a variant cannot be selected because there are no variants, mentio… 

    …n that

instead of saying that every variant has no attributes

Fixes: gradle#28970

Signed-off-by: Jeff Gaston <gastoj3@gmail.com>
    @mathjeff
    mathjeff committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    5487c57 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Reroute no variants exist failure through a new resolution failure path 

    - Clarify error message.
- Use an IncompatibleGraphVariantFailure instead of ConfigurationNotFoundFailure, which fixes tests to pass by causing proper FailureDescriber to fire.
- Add no variants exist failure demonstration to error showcase.
    @tresat
    tresat committed May 7, 2024
    Configuration menu
    Copy the full SHA
    f918696 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Update test expectations to contain the new failure message 

    - This new message clarifies the situation in each of these cases.
    @tresat
    tresat committed May 8, 2024
    Configuration menu
    Copy the full SHA
    a071736 View commit details
    Browse the repository at this point in the history

  2. Add more specific suggestion in case of no existing variants failure

    @tresat
    tresat committed May 8, 2024
    Configuration menu
    Copy the full SHA
    1fa35fc View commit details
    Browse the repository at this point in the history

  3. Correct test expectations to update docs recommendation and succeed o… 

    …n CI
    @tresat
    tresat committed May 8, 2024
    Configuration menu
    Copy the full SHA
    8c1db00 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Update test expectations to use in-use JavaVersion number

    @tresat
    tresat committed May 9, 2024
    Configuration menu
    Copy the full SHA
    4b0e271 View commit details
    Browse the repository at this point in the history