Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Upgrade Note for Strongly Typed Dependencies in Test Suites #22778
Add Upgrade Note for Strongly Typed Dependencies in Test Suites #22778
Changes from 5 commits
f9e3225
f8d87f8
a5e772b
6032175
29aeab2
0df577d
716906d
10302c4
d14cc44
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: as an incubating API, I assume users are aware we are continually tweaking and improving things. Better to avoid the confusing pronoun usage, eliminate the intro, and keep the sentence trim.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the intro here. I think part of the reason for this note existing is to head of criticism in the form of "Why did this minor version upgrade suddenly break my build?" Re-emphasizing the incubating and changing status of the API seems worthwhile, and might prevent some angry feedback/issues. I like the changes after that clause.