Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for EnableExternalDTDLoad property to Checkstyle Plugin #22036
Adds support for EnableExternalDTDLoad property to Checkstyle Plugin #22036
Changes from 1 commit
e3dfe55
f0ea951
1ae7049
6ff69c5
dda8055
3a85057
617a584
f3aece7
13ba0d3
3548f39
91a48ab
4d01de7
02549cf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would do this slightly differently. Instead of checking if the property is present, let's just put a
convention(false)
onenableExternalDtdLoad
in the constructor. I would then also drop the@Optional
annotation below.That way if someone uses the Checkstyle task without the Checkstyle plugin, they'll have a value. This is similar to what we're doing with the toolchain.
This is against the usual pattern (conventions should be set in the plugin), but as long as we support Checkstyle tasks to be used outside of the plugin, we have to keep them working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to avoid setting the convention in the constructor, and also to avoid needlessly setting an extra system property set to false (which means the same as absence) when running the checkstyle process.
Are you sure we shouldn't leave the
@Optional
and usegetOrNull()
to match the other fork options (these do NOT create system props, but still)?