Add Convention Develocity Maven extension #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayburn
force-pushed
the
cj/convention-maven-extension
branch
from
2fed8d0
to
ddd20ea
Compare
clayburn
commented
Mar 17, 2023
gradle-enterprise-conventions-maven-extension/extension/src/main/java/com/example/CiUtils.java
Outdated
Show resolved
Hide resolved
gradle-enterprise-conventions-maven-extension/extension/pom.xml
Outdated
Show resolved
Hide resolved
gradle-enterprise-conventions-maven-extension/extension/README.md
Outdated
Show resolved
Hide resolved
clayburn
force-pushed
the
cj/convention-maven-extension
branch
from
2e47869
to
591f7a7
Compare
bigdaz
reviewed
Mar 20, 2023
gradle-enterprise-conventions-maven-extension/example-builds/maven_3.6.x/.mvn/extensions.xml
Outdated
Show resolved
Hide resolved
gradle-enterprise-conventions-maven-extension/extension/.mvn/extensions.xml
Outdated
Show resolved
Hide resolved
gradle-enterprise-conventions-maven-extension/extension/.mvn/gradle-enterprise.xml
Outdated
Show resolved
Hide resolved
gradle-enterprise-conventions-maven-extension/extension/src/main/java/com/example/CiUtils.java
Outdated
Show resolved
Hide resolved
...ntions-maven-extension/extension/src/main/java/com/example/CustomGradleEnterpriseConfig.java
Outdated
Show resolved
Hide resolved
runningcode
reviewed
Mar 21, 2023
jprinet
approved these changes
Mar 21, 2023
gradle-enterprise-conventions-maven-extension/example-builds/maven_3.6.x/pom.xml
Outdated
Show resolved
Hide resolved
gradle-enterprise-conventions-maven-extension/example-builds/maven_3.6.x/pom.xml
Outdated
Show resolved
Hide resolved
gradle-enterprise-conventions-maven-extension/example-builds/maven_3.9.x/pom.xml
Outdated
Show resolved
Hide resolved
gradle-enterprise-conventions-maven-extension/extension/.mvn/extensions.xml
Outdated
Show resolved
Hide resolved
gradle-enterprise-conventions-maven-extension/extension/.mvn/gradle-enterprise.xml
Outdated
Show resolved
Hide resolved
runningcode
reviewed
Mar 21, 2023
runningcode
reviewed
Mar 21, 2023
...conventions-maven-extension/example-builds/maven_3.6.x/.mvn/wrapper/maven-wrapper.properties
Outdated
Show resolved
Hide resolved
|
@clayburn I have not gotten to review this, yet, but please make sure all of this runs on Java 8, incl. the build itself. Similarly, the approach of this convention should work on Maven 3.6, 3.7, 3.8, and 3.9. thanks. |
clayburn
force-pushed
the
cj/convention-maven-extension
branch
from
4329f7f
to
d97f488
Compare
etiennestuder
requested changes
Aug 10, 2023
...le-enterprise-conventions-maven-extension/extension/src/main/resources/gradle-enterprise.xml
Outdated
Show resolved
Hide resolved
jprinet
reviewed
Aug 11, 2023
.github/workflows/gradle-enterprise-conventions-maven-extension-verification.yml
Outdated
Show resolved
Hide resolved
clayburn
force-pushed
the
cj/convention-maven-extension
branch
3 times, most recently
from
f227520
to
573db6b
Compare
ribafish
reviewed
Sep 12, 2023
jprinet
reviewed
Mar 1, 2024
...sion/extension/src/main/java/com/myorg/ConventionGradleEnterpriseMavenExtensionListener.java
Outdated
Show resolved
Hide resolved
|
This needs some attention. I'm going to close it but leave the branch around for now until we want to prioritize it again. |
erichaagdev
force-pushed
the
cj/convention-maven-extension
branch
from
9a1dace
to
75f60b7
Compare
erichaagdev
changed the title
erichaagdev
changed the title
erichaagdev
reviewed
May 16, 2024
convention-develocity-maven-extension/example/.mvn/extensions.xml
Outdated
Show resolved
Hide resolved
erichaagdev
force-pushed
the
cj/convention-maven-extension
branch
2 times, most recently
from
1e7ce45
to
f4cc495
Compare
erichaagdev
force-pushed
the
cj/convention-maven-extension
branch
from
f4cc495
to
19e0948
Compare
erichaagdev
requested review from
a team,
ribafish,
jprinet,
erichaagdev,
runningcode,
etiennestuder and
bigdaz
clayburn
commented
May 17, 2024
.github/workflows/convention-develocity-maven-extension-verification.yml
Outdated
Show resolved
Hide resolved
convention-develocity-maven-extension/examples/maven_3.6/pom.xml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a sample Maven extension that applies Develocity, Common Custom User Data Maven extension, and a reasonable set of defaults for configuring build scans and build caching. The goal is to provide a sample that makes it simple for organizations to create and host their own, customized version of this extension in order to more easily and consistently apply Develocity configurations across an organization.