Refactor Initialization of Configuration File Merger #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
fniephaus
reviewed
Apr 8, 2024
...en-plugin/src/main/java/org/graalvm/buildtools/maven/config/AbstractMergeAgentFilesMojo.java
Outdated
Show resolved
Hide resolved
...en-plugin/src/main/java/org/graalvm/buildtools/maven/config/AbstractMergeAgentFilesMojo.java
Outdated
Show resolved
Hide resolved
|
@fniephaus @melix @alvarosanchez please take a look on this PR when you catch some time. I would like to merge it if it looks okay (since it is open while ago) |
alvarosanchez
previously approved these changes
May 21, 2024
fniephaus
reviewed
May 21, 2024
...en-plugin/src/main/java/org/graalvm/buildtools/maven/config/AbstractMergeAgentFilesMojo.java
Outdated
Show resolved
Hide resolved
...en-plugin/src/main/java/org/graalvm/buildtools/maven/config/AbstractMergeAgentFilesMojo.java
Show resolved
Hide resolved
...en-plugin/src/main/java/org/graalvm/buildtools/maven/config/AbstractMergeAgentFilesMojo.java
Outdated
Show resolved
Hide resolved
melix
previously approved these changes
May 21, 2024
fniephaus
previously approved these changes
May 22, 2024
...e-maven-plugin/src/main/java/org/graalvm/buildtools/utils/NativeImageConfigurationUtils.java
Outdated
Show resolved
Hide resolved
fniephaus
previously approved these changes
May 23, 2024
dnestoro
force-pushed
the
dnestoro/RefactorInitializationOfConfigurtaionFileMerger
branch
from
516e740
to
6a419c6
Compare
fniephaus
approved these changes
May 23, 2024
dnestoro
deleted the
dnestoro/RefactorInitializationOfConfigurtaionFileMerger
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove macro from merger init and throw better error if executable does not exist