Make GraalVM installation check lazy #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add-reachability-metadata goal can now be run with a regular JDK. Closes graalvmgh-327
oracle-contributor-agreement
bot
added
the
OCA Verified
|
@aclement Please give your agreement for merging this PR. |
alvarosanchez
approved these changes
Oct 24, 2022
|
looks good to me. |
sschuberth
reviewed
Oct 26, 2022
| @@ -360,4 +352,12 @@ private static Xpp3Dom findOrAppend(Xpp3Dom parent, String childName) { | |||
| return child; | |||
| } | |||
|
|
|||
| private static String getGraalvmJava() { | |||
There was a problem hiding this comment.
Nit: Shouldn't this better be camel-cased like getGraalVmJava?
dnestoro
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add-reachability-metadatagoal can now be run with a regular JDK.Closes gh-327