Add basic support for Docker, both for development and deploy #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o Code) and deploy
For the OpenAIP layer to work, the "openaip" key (you cen get one from https://openaip.net/) should be provided in the `res/config.json` file.
thomasgubler
reviewed
Jan 9, 2024
| @@ -0,0 +1,55 @@ | |||
| // For format details, see https://aka.ms/devcontainer.json. For config options, see the README at: | |||
| // https://github.com/microsoft/vscode-dev-containers/tree/v0.183.0/containers/dotnet | |||
There was a problem hiding this comment.
why do you base it on the dotnet template? (also commented out configs further below)
Would the python3 template make more sense?
https://github.com/microsoft/vscode-dev-containers/tree/v0.183.0/containers/python-3
There was a problem hiding this comment.
I just used an image to let me debug.
Please, feel free to change it to anything more appropriate!
thomasgubler
reviewed
Jan 9, 2024
| # In Visual Studio Code: | ||
| # edit ./res/config.json and set your API keys | ||
| # open a terminal and run: | ||
| # python3 -m http.server |
There was a problem hiding this comment.
maybe we could use postStartCommand https://code.visualstudio.com/remote/advancedcontainers/start-processes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic support for Docker, both for development (with Visual Studio Code) and deploy.
This PR adds the capability to develop the project in container with Visual Studio Code (settings in the
.devcontainerfolder).It also provides some raw support to run a python
http.serverin a Docker container, updating theres/config.jsfile according to the specified environment variables at startup (seerun.shandDockerfile).