Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: matcherToArray should return a copy of the array #1609

Merged
merged 1 commit into from Nov 20, 2022
Merged

fix: matcherToArray should return a copy of the array #1609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/react-day-picker/src/contexts/Modifiers/utils/matcherToArray.test.ts
View file
Open in desktop
Expand Up @@ -10,8 +10,11 @@ describe('when a Matcher is passed in', () => {
});

describe('when an array of Matchers is passed in', () => {
test('should return the array', () => {
expect(matcherToArray([matcher])).toStrictEqual([matcher]);
test('should return a copy of the array', () => {
const value = [matcher, matcher];
const result = matcherToArray(value);
expect(result).toStrictEqual(value);
expect(result).not.toBe(value);
});
});

Expand Down
2 changes: 1 addition & 1 deletion packages/react-day-picker/src/contexts/Modifiers/utils/matcherToArray.ts
View file
Open in desktop
Expand Up @@ -5,7 +5,7 @@ export function matcherToArray(
matcher: Matcher | Matcher[] | undefined
): Matcher[] {
if (Array.isArray(matcher)) {
return matcher;
return [...matcher];
} else if (matcher !== undefined) {
return [matcher];
} else {
Expand Down